Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

weird https url for wicked-good-xpath in package.json #175

Open
JJJHolscher opened this issue Oct 1, 2024 · 0 comments
Open

weird https url for wicked-good-xpath in package.json #175

JJJHolscher opened this issue Oct 1, 2024 · 0 comments

Comments

@JJJHolscher
Copy link

JJJHolscher commented Oct 1, 2024

package.json contains this line

"wicked-good-xpath": "git+https://[email protected]/zotero/wicked-good-xpath.git#1b88459",

Which nix's buildNpmPackage recognises as an ssh url and thereby errors.
I'm not experienced in packaging with npm, but I expect that line should omit the git@ and just look like.

"wicked-good-xpath": "git+https://github.com/zotero/wicked-good-xpath.git#1b88459",

That at least works in my fork of this repo that contains the said flake.nix.

If this could be patched here, then I'd have less of a need to maintain my own fork and could just have a separate flake that points to this github.
(I can also patch inside of my flake, but that process is a bit fickle though I might fall back to that if this is not or can not be addressed.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant