Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support not only OpenShift #2

Open
MPV opened this issue Aug 22, 2024 · 3 comments
Open

Support not only OpenShift #2

MPV opened this issue Aug 22, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@MPV
Copy link

MPV commented Aug 22, 2024

Would you be up for adding/changing/supporting a non-OpenShift-only helm chart?

As it is today, I guess it's only the SecurityContextConstraints resource that isn't portable to vanilla Kubernetes (?), i.e:

@MPV MPV added the enhancement New feature or request label Aug 22, 2024
@drew0ps
Copy link

drew0ps commented Aug 29, 2024

Hi @MPV,

My thoughts exactly, that is why I added #1 to make the flag .Values.zsglobal.securityContextConstraints.create work. I've installed it on a local vanilla Kube cluster and for me it seems to work.

@MPV
Copy link
Author

MPV commented Sep 6, 2024

Now that the changes coming in #1 are on the way, as it will thus support not-only OpenShift, could this repo also be renamed (for discoverability) to reflect that the helm chart could work with vanilla Kubernetes as well?

Also considering the documentation on the Docker page saying Kubernetes isn't supported:

"Docker support is not available for Kubernetes."
https://help.zscaler.com/zpa/app-connector-deployment-guide-docker

@MPV
Copy link
Author

MPV commented Sep 6, 2024

Would you also say/recommend that the zsglobal.openshiftEnvironment.value value should be set to some (which?) other value than enabled?

zpa-openshift/values.yaml

Lines 144 to 147 in 5b08eb7

## @param zsglobal.openshiftEnvironment Notify the App Connector about running on Openshift.
openshiftEnvironment:
## @param zsglobal.openshiftEnvironment.value Openshift platform detection enabled/disabled.
value: "enabled"

- name: OPENSHIFT_ENVIRONMENT
value: {{ (.Values.zsglobal.openshiftEnvironment).value }}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants