Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: zurb/tribute
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 5.1.2
Choose a base ref
...
head repository: zurb/tribute
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref

Commits on Mar 6, 2020

  1. Remove noMatchTemplate on autocomplete.

    Jordan Humphreys committed Mar 6, 2020
    Copy the full SHA
    afb5662 View commit details

Commits on Mar 10, 2020

  1. Document hiding menu with no match.

    Jordan Humphreys committed Mar 10, 2020
    Copy the full SHA
    c204e32 View commit details

Commits on Mar 25, 2020

  1. Fix minified build, bump version.

    Jordan Humphreys committed Mar 25, 2020
    Copy the full SHA
    65d4a49 View commit details

Commits on Mar 27, 2020

  1. Bump rollup-plugin-babel from 4.3.3 to 4.4.0 (#427)

    Bumps [rollup-plugin-babel](https://github.com/rollup/rollup-plugin-babel) from 4.3.3 to 4.4.0.
    - [Release notes](https://github.com/rollup/rollup-plugin-babel/releases)
    - [Changelog](https://github.com/rollup/rollup-plugin-babel/blob/master/CHANGELOG.md)
    - [Commits](rollup/rollup-plugin-babel@v4.3.3...v4.4.0)
    
    Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
    
    Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
    dependabot-preview[bot] authored Mar 27, 2020
    Copy the full SHA
    a250551 View commit details
  2. Bump rollup-plugin-terser from 5.2.0 to 5.3.0 (#428)

    Bumps [rollup-plugin-terser](https://github.com/TrySound/rollup-plugin-terser) from 5.2.0 to 5.3.0.
    - [Release notes](https://github.com/TrySound/rollup-plugin-terser/releases)
    - [Commits](TrySound/rollup-plugin-terser@v5.2.0...v5.3.0)
    
    Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
    
    Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
    dependabot-preview[bot] authored Mar 27, 2020
    Copy the full SHA
    da8f9a1 View commit details
  3. Bump rollup-plugin-livereload from 1.0.4 to 1.1.0 (#431)

    Bumps [rollup-plugin-livereload](https://github.com/thgh/rollup-plugin-livereload) from 1.0.4 to 1.1.0.
    - [Release notes](https://github.com/thgh/rollup-plugin-livereload/releases)
    - [Changelog](https://github.com/thgh/rollup-plugin-livereload/blob/master/CHANGELOG.md)
    - [Commits](https://github.com/thgh/rollup-plugin-livereload/commits)
    
    Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
    
    Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
    dependabot-preview[bot] authored Mar 27, 2020
    Copy the full SHA
    cf190cb View commit details
  4. Bump @babel/preset-env from 7.8.7 to 7.9.0 (#433)

    Bumps [@babel/preset-env](https://github.com/babel/babel) from 7.8.7 to 7.9.0.
    - [Release notes](https://github.com/babel/babel/releases)
    - [Changelog](https://github.com/babel/babel/blob/master/CHANGELOG.md)
    - [Commits](babel/babel@v7.8.7...v7.9.0)
    
    Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
    
    Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
    dependabot-preview[bot] authored Mar 27, 2020
    Copy the full SHA
    b53a6c4 View commit details
  5. Bump karma-jasmine-html-reporter from 1.5.2 to 1.5.3 (#435)

    Bumps [karma-jasmine-html-reporter](https://github.com/dfederm/karma-jasmine-html-reporter) from 1.5.2 to 1.5.3.
    - [Release notes](https://github.com/dfederm/karma-jasmine-html-reporter/releases)
    - [Commits](dfederm/karma-jasmine-html-reporter@v1.5.2...v1.5.3)
    
    Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
    
    Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
    dependabot-preview[bot] authored Mar 27, 2020
    Copy the full SHA
    75a027c View commit details
  6. Bump @babel/core from 7.8.7 to 7.9.0 (#434)

    Bumps [@babel/core](https://github.com/babel/babel) from 7.8.7 to 7.9.0.
    - [Release notes](https://github.com/babel/babel/releases)
    - [Changelog](https://github.com/babel/babel/blob/master/CHANGELOG.md)
    - [Commits](babel/babel@v7.8.7...v7.9.0)
    
    Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
    
    Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
    dependabot-preview[bot] authored Mar 27, 2020
    Copy the full SHA
    b086424 View commit details

Commits on May 2, 2020

  1. Add autocompleteSeparator parameter (#406)

    * push improved autocomplete functionality
    
    * actual autocomplete fixes
    
    * push missing changes
    
    * add autocompleteSeparator parameter
    
    * remove debugger
    
    * make gulfile syntax more consistent
    
    * remove unnecessary gulpfile changes
    
    * test autocompleteSeparator
    
    Co-authored-by: Valentin Steinwandter <valentin.steinwandter@exputec.com>
    valentinstn and valentinsteinwandter authored May 2, 2020
    Copy the full SHA
    2d03516 View commit details

Commits on Jun 6, 2020

  1. 1
    Copy the full SHA
    99e4a3d View commit details
  2. Add menuItemLimit to README and types (#447)

    * Add menuItemLimit to README
    
    * Add menuItemLimit to tributejs.d.ts
    jseminck authored Jun 6, 2020
    Copy the full SHA
    2a21d85 View commit details

Commits on Jun 7, 2020

  1. Loading item template (#490)

    * Add loadingItemTemplate property
    
    * Update README and type definition
    
    * Fix loading template when mulitple triggers, rebase on master
    
    Co-authored-by: Joachim Seminck <joachim.seminck@pipedrive.com>
    cgross and jseminck authored Jun 7, 2020
    Copy the full SHA
    13bbef7 View commit details

Commits on Aug 3, 2020

  1. [Security] Bump lodash from 4.17.15 to 4.17.19 (#521)

    Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.19. **This update includes a security fix.**
    - [Release notes](https://github.com/lodash/lodash/releases)
    - [Commits](lodash/lodash@4.17.15...4.17.19)
    
    Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
    
    Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
    dependabot-preview[bot] authored Aug 3, 2020
    Copy the full SHA
    511fd73 View commit details
  2. [Security] Bump elliptic from 6.5.2 to 6.5.3 (#531)

    Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.2 to 6.5.3. **This update includes a security fix.**
    - [Release notes](https://github.com/indutny/elliptic/releases)
    - [Commits](indutny/elliptic@v6.5.2...v6.5.3)
    
    Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
    
    Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
    dependabot-preview[bot] authored Aug 3, 2020
    Copy the full SHA
    e4edbac View commit details

Commits on Oct 13, 2020

  1. [Security] Bump http-proxy from 1.18.0 to 1.18.1 (#549)

    Bumps [http-proxy](https://github.com/http-party/node-http-proxy) from 1.18.0 to 1.18.1. **This update includes a security fix.**
    - [Release notes](https://github.com/http-party/node-http-proxy/releases)
    - [Changelog](https://github.com/http-party/node-http-proxy/blob/master/CHANGELOG.md)
    - [Commits](http-party/node-http-proxy@1.18.0...1.18.1)
    
    Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
    
    Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
    dependabot-preview[bot] authored Oct 13, 2020
    Copy the full SHA
    05dd4c7 View commit details

Commits on Oct 14, 2020

  1. Fix and update the TypeScript typings (#553)

    * Add autocompleteSeparator to type definition file.
    
    * Add spaceSelectsMatch to type definition file.
    
    * Fix type definition file by specifying array type.
    simonlary authored Oct 14, 2020
    Copy the full SHA
    cc67538 View commit details
  2. quilljs compat (#554)

    agrafix authored Oct 14, 2020
    Copy the full SHA
    27d56cb View commit details

Commits on Nov 30, 2020

  1. Remove redundant code related to whitespace characters (#563)

    * Update TributeRange.js
    
    * Update TributeRange.js
    
    * Update TributeRange.js
    jwbth authored Nov 30, 2020
    Copy the full SHA
    de47a92 View commit details
  2. Fixed wrong if (window) check (#508)

    `if (window)` it is incorrect check that throws `ReferenceError` error in non-browser environment. When you want to check potentially uninitialised variable, you must do it using typeof construction. Btw, i'm getting `ReferenceError: window is not defined` when u just import tribute (w/o `new Tribute`) in Node js (server side rendering). It's strange, i supposed, that initialisation runs after i call `new Tribute`.
    f0rmat1k authored Nov 30, 2020
    Copy the full SHA
    f4bd8d2 View commit details

Commits on Jan 12, 2021

  1. [Security] Bump ini from 1.3.5 to 1.3.8 (#587)

    Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.8. **This update includes a security fix.**
    - [Release notes](https://github.com/isaacs/ini/releases)
    - [Commits](npm/ini@v1.3.5...v1.3.8)
    
    Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
    
    Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
    dependabot-preview[bot] authored Jan 12, 2021
    Copy the full SHA
    72a9700 View commit details

Commits on Mar 2, 2021

  1. Compatibility with IE11 (#592)

    I have some Problems with the old implementation under IE11, it throw Exceptions and/or produce unwanted behavior in other JS (eg JQuery).
    fglueck authored Mar 2, 2021
    Copy the full SHA
    5d63790 View commit details

Commits on Sep 24, 2021

  1. Fix spaceSelectsMatch causing error (fixes #495) (#529)

    With `spaceSelectsMatch` enabled, an error `Uncaught TypeError: Cannot
    read property '0' of undefined` is sometimes given when attempting to
    autocomplete with any of space, tab, or enter.
    
    The cause appears to be that with this option enabled, sometimes this
    code path intended to handle KeyboardEvents will be entered again after
    handling a KeyboardEvent with another type of event (CustomEvent); this
    then later causes this error as `this.current.filteredItems` is now
    `undefined`, as the original KeyboardEvent has already been handled.
    
    Checking whether the event looks like a KeyboardEvent, and returning
    early if it doesn't, appears to resolve this.
    bobwhitelock authored Sep 24, 2021
    Copy the full SHA
    046ae53 View commit details
  2. Upgrade to GitHub-native Dependabot (#652)

    Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
    dependabot-preview[bot] authored Sep 24, 2021
    Copy the full SHA
    33b51ae View commit details
  3. Bump rollup-plugin-serve from 1.0.1 to 1.1.0 (#701)

    Bumps [rollup-plugin-serve](https://github.com/thgh/rollup-plugin-serve) from 1.0.1 to 1.1.0.
    - [Release notes](https://github.com/thgh/rollup-plugin-serve/releases)
    - [Changelog](https://github.com/thgh/rollup-plugin-serve/blob/master/CHANGELOG.md)
    - [Commits](thgh/rollup-plugin-serve@v1.0.1...v1.1.0)
    
    ---
    updated-dependencies:
    - dependency-name: rollup-plugin-serve
      dependency-type: direct:development
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Sep 24, 2021
    Copy the full SHA
    c3dc822 View commit details
  4. Bump rollup-plugin-terser from 5.3.0 to 5.3.1 (#699)

    Bumps [rollup-plugin-terser](https://github.com/TrySound/rollup-plugin-terser) from 5.3.0 to 5.3.1.
    - [Release notes](https://github.com/TrySound/rollup-plugin-terser/releases)
    - [Commits](TrySound/rollup-plugin-terser@v5.3.0...v5.3.1)
    
    ---
    updated-dependencies:
    - dependency-name: rollup-plugin-terser
      dependency-type: direct:development
      update-type: version-update:semver-patch
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Sep 24, 2021
    Copy the full SHA
    dc6e13b View commit details
  5. [Security] Bump lodash from 4.17.19 to 4.17.21 (#662)

    Bumps [lodash](https://github.com/lodash/lodash) from 4.17.19 to 4.17.21. **This update includes a security fix.**
    - [Release notes](https://github.com/lodash/lodash/releases)
    - [Commits](lodash/lodash@4.17.19...4.17.21)
    
    Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
    
    Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
    dependabot-preview[bot] authored Sep 24, 2021
    Copy the full SHA
    8238200 View commit details
  6. Bump rollup-plugin-livereload from 1.1.0 to 2.0.5 (#682)

    Bumps [rollup-plugin-livereload](https://github.com/thgh/rollup-plugin-livereload) from 1.1.0 to 2.0.5.
    - [Release notes](https://github.com/thgh/rollup-plugin-livereload/releases)
    - [Changelog](https://github.com/thgh/rollup-plugin-livereload/blob/master/CHANGELOG.md)
    - [Commits](https://github.com/thgh/rollup-plugin-livereload/commits/v2.0.5)
    
    Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
    
    Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
    dependabot-preview[bot] authored Sep 24, 2021
    Copy the full SHA
    169e376 View commit details

Commits on Sep 25, 2021

  1. Copy the full SHA
    2d281aa View commit details

Commits on Oct 18, 2021

  1. Multiple positioning fixes (#491)

    * many positioning fixes
    
    * Changing all positioning to use viewport relative fixed positioning
    cgross authored Oct 18, 2021
    Copy the full SHA
    55293f1 View commit details

Commits on Dec 15, 2021

  1. Copy the full SHA
    252ec34 View commit details
Showing with 1,022 additions and 773 deletions.
  1. +58 −0 .github/dependabot.yml
  2. +2 −1 .gitignore
  3. +17 −1 README.md
  4. +0 −2 dist/tribute.css
  5. +104 −136 dist/tribute.esm.js
  6. +128 −135 dist/tribute.js
  7. +1 −1 dist/tribute.min.js
  8. +1 −1 dist/tribute.min.js.map
  9. +13 −7 example/index.html
  10. +0 −2 example/tribute.css
  11. +128 −135 example/tribute.js
  12. +2 −2 package.json
  13. +1 −1 rollup.config.js
  14. +17 −6 src/Tribute.js
  15. +7 −7 src/TributeEvents.js
  16. +4 −4 src/TributeMenuEvents.js
  17. +83 −131 src/TributeRange.js
  18. +5 −1 src/TributeSearch.js
  19. +0 −2 src/tribute.scss
  20. +44 −21 src/utils.js
  21. +80 −0 test/spec/test.js
  22. +0 −2 tribute.css
  23. +19 −5 tributejs.d.ts
  24. +308 −170 yarn.lock
58 changes: 58 additions & 0 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
version: 2
updates:
- package-ecosystem: npm
directory: "/"
schedule:
interval: daily
time: "09:00"
open-pull-requests-limit: 10
ignore:
- dependency-name: "@babel/core"
versions:
- 7.12.10
- 7.12.13
- 7.12.16
- 7.12.17
- 7.13.1
- 7.13.10
- 7.13.13
- 7.13.14
- 7.13.15
- 7.13.8
- dependency-name: karma
versions:
- 6.0.3
- 6.0.4
- 6.1.0
- 6.1.1
- 6.1.2
- 6.2.0
- 6.3.0
- 6.3.1
- dependency-name: "@babel/preset-env"
versions:
- 7.12.11
- 7.12.13
- 7.12.16
- 7.12.17
- 7.13.0
- 7.13.10
- 7.13.12
- 7.13.5
- 7.13.8
- 7.13.9
- dependency-name: puppeteer
versions:
- 5.5.0
- 6.0.0
- 7.0.0
- 7.0.1
- 7.0.3
- 7.0.4
- 7.1.0
- 8.0.0
- dependency-name: "@rollup/plugin-node-resolve"
versions:
- 11.1.0
- 11.1.1
- 11.2.0
3 changes: 2 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
@@ -2,4 +2,5 @@ node_modules
.DS_Store
npm-debug.log
test/coverage
yarn-error.log
yarn-error.log
.idea
18 changes: 17 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -169,9 +169,12 @@ Collection object shown with defaults:
// column that contains the content to insert by default
fillAttr: 'value',

// REQUIRED: array of objects to match
// REQUIRED: array of objects to match or a function that returns data (see 'Loading remote data' for an example)
values: [],

// When your values function is async, an optional loading template to show
loadingItemTemplate: null,

// specify whether a space is required before the trigger string
requireLeadingSpace: true,

@@ -200,6 +203,9 @@ Collection object shown with defaults:
skip: false // true will skip local search, useful if doing server-side search
},

// Limits the number of items in the menu
menuItemLimit: 25,

// specify the minimum number of characters that must be typed before menu appears
menuShowMinLength: 0
}
@@ -441,6 +447,16 @@ function remoteSearch(text, cb) {
}
```

### Hide menu when no match is returned

If you want the menu to not show when no match is found, you can set your `noMatchTemplate` config to the following:

```js
noMatchTemplate: function () {
return '<span style:"visibility: hidden;"></span>';
}
```

### Detaching Tribute instances

When you want to remove Tribute from an element you can call `detach`.
2 changes: 0 additions & 2 deletions dist/tribute.css
Original file line number Diff line number Diff line change
@@ -3,8 +3,6 @@
top: 0;
left: 0;
height: auto;
max-height: 300px;
max-width: 500px;
overflow: auto;
display: block;
z-index: 999999;
Loading