Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CON-2526 add new GA to check for broken links #2510

Merged

Conversation

nprimo
Copy link
Contributor

@nprimo nprimo commented Mar 26, 2024

Before merging:

  • be sure that the new label to skip check is added
  • consider moving the GA to 01-edu

@nprimo nprimo self-assigned this Mar 26, 2024
Copy link
Member

@Frenchris Frenchris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. the "uses: nprimo/[email protected]" will need to be forked or changed to our organization after tests of the script are satisfactory.

Copy link
Member

@Frenchris Frenchris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It just needs the change to point to 01-edu/check-links

- bump up the GA version used to have the latest
@nprimo nprimo marked this pull request as ready for review March 26, 2024 17:50
@nprimo nprimo requested a review from Frenchris March 26, 2024 17:50
Copy link
Member

@Frenchris Frenchris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :)

@nprimo nprimo merged commit 4dd6157 into master Mar 28, 2024
1 check passed
@nprimo nprimo deleted the CON-2526-add-ga-to-check-links-for-new-or-changed-markdown-files branch March 28, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants