Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CON-2520-checkpoints-group-1 #2511

Merged
merged 10 commits into from
May 15, 2024
Merged

CON-2520-checkpoints-group-1 #2511

merged 10 commits into from
May 15, 2024

Conversation

zanninso
Copy link
Contributor

No description provided.

@zanninso zanninso requested a review from nprimo March 26, 2024 14:58
nprimo
nprimo suggested changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@nprimo nprimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments inline

subjects/java/checkpoints/universal-greeting/README.md Show resolved Hide resolved
subjects/java/checkpoints/universal-greeting/README.md Outdated Show resolved Hide resolved
subjects/java/checkpoints/helloworld/README.md Outdated Show resolved Hide resolved
@zanninso zanninso requested a review from nprimo March 27, 2024 15:27
nprimo
nprimo suggested changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@nprimo nprimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a small typo and I have added a format suggestion. Everything else look good to me.

subjects/java/checkpoints/good-by-mars/README.md Outdated Show resolved Hide resolved
subjects/java/checkpoints/good-by-mars/README.md Outdated Show resolved Hide resolved
subjects/java/checkpoints/system-logger/README.md Outdated Show resolved Hide resolved
subjects/java/checkpoints/universal-greeting/README.md Outdated Show resolved Hide resolved
@zanninso zanninso requested a review from nprimo March 27, 2024 16:14
nprimo
nprimo suggested changes Mar 27, 2024
View reviewed changes
subjects/java/checkpoints/good-bye-mars/README.md Outdated Show resolved Hide resolved
subjects/java/checkpoints/universal-greeting/README.md Outdated Show resolved Hide resolved
subjects/java/checkpoints/good-bye-mars/README.md Outdated Show resolved Hide resolved
subjects/java/checkpoints/universal-greeting/README.md Outdated Show resolved Hide resolved
@zanninso zanninso requested a review from nprimo March 27, 2024 17:44
nprimo
nprimo suggested changes Apr 1, 2024
View reviewed changes
Copy link
Contributor

@nprimo nprimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some small errors in the provided code snippets.

subjects/java/checkpoints/system-logger/README.md Outdated Show resolved Hide resolved
subjects/java/checkpoints/universal-greeting/README.md Outdated Show resolved Hide resolved
@zanninso zanninso requested a review from nprimo April 3, 2024 08:18
nprimo
nprimo approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@nprimo nprimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zanninso zanninso merged commit 15b223d into master May 15, 2024
3 checks passed
@zanninso zanninso deleted the CON-2520-checkpoints-group-1 branch May 15, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nprimo nprimo nprimo approved these changes

Assignees

@zanninso zanninso

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zanninso @nprimo