Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EXTERNAL] ♻️ better explanation for Cat #2535

Merged
merged 3 commits into from
May 21, 2024

Conversation

quentin-desbin
Copy link
Contributor

We are using this exercice for some students and the explanation was unclear. I suggest these changes to make it more clear and more visible.

@quentin-desbin
Copy link
Contributor Author

@nprimo Hello, sorry to ping you but you appears to be active on this repo, I can't add any reviewer/assignee to this MR, but it can be cool to review/merge it, thanks !

@nprimo
Copy link
Contributor

nprimo commented May 16, 2024

Hi @quentin-desbin, thank you for your contribution - I'll see if someone from our team can have a look at this and take care of this PR :)

@nprimo nprimo requested a review from zanninso May 16, 2024 13:08
the version 21 is still new and its not included in all the piscine.
Copy link
Contributor

@zanninso zanninso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zanninso
Copy link
Contributor

Hello @quentin-desbin thank you for your contribution!
your suggestions looks good and it will be merged thank you again.

@zanninso zanninso merged commit 34d0307 into 01-edu:master May 21, 2024
3 checks passed
@HarryVasanth HarryVasanth changed the title ♻️ better explanation for Cat [EXTERNAL] ♻️ better explanation for Cat Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants