Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EXTERNAL] Remove conflicting traits from expected data structure from rust-roman_numbers #2834

Merged
merged 1 commit into from
Jan 1, 2025

Conversation

heshamalmosawi
Copy link
Contributor

Why?

The expected functions and Usage of the roman_numbers task of the traits quest has a conflicting implementation of traits, aka duplicate usage of the debug trait, which leads to compilation error. This PR removes this conflict/duplication of traits.

Solution Overview

The solution only removes the duplicate trait from the readme, to remove the duplication and avoid the compilation error.

@pedrodesu pedrodesu self-requested a review January 1, 2025 19:10
@pedrodesu pedrodesu self-assigned this Jan 1, 2025
@pedrodesu
Copy link
Contributor

Looks good to me! Thank you very much for spotting this mistake and submitting the PR. I should also warn you the team is working on refining and updating the Rust content comprehensively at the moment, so this type of mistake should be fixed promptly, as with other improvements that will be curated.

@pedrodesu pedrodesu merged commit 35a19c5 into 01-edu:master Jan 1, 2025
10 of 12 checks passed
@HarryVasanth HarryVasanth changed the title fix(rust-roman_numbers): remove conflicting traits from expected data structure [EXTERNAL] Remove conflicting traits from expected data structure from rust-roman_numbers Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants