Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(util): conditional sudo for some install_protoc commands #117

Merged
merged 1 commit into from
Nov 24, 2023
Merged

fix(util): conditional sudo for some install_protoc commands #117

merged 1 commit into from
Nov 24, 2023

Conversation

nourspace
Copy link
Contributor

This was failing when run by root

./util/dev_setup.sh: line 168: sudo: command not found
make: *** [Makefile:53: install] Error 127

hemulin
hemulin approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@hemulin hemulin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@The1OneID The1OneID mentioned this pull request Nov 24, 2023
Closed
@nourspace
Copy link
Contributor Author

@hemulin I can't merge

@hemulin hemulin merged commit 54401ac into 0LNetworkCommunity:release-6.9.0-rc.10 Nov 24, 2023
@hemulin
Copy link
Contributor

hemulin commented Nov 24, 2023

I got you. Thanks @nourspace 🙇

@nourspace nourspace deleted the patch-1 branch November 25, 2023 08:43
0o-de-lally pushed a commit that referenced this pull request Nov 30, 2023
@nourspace @0o-de-lally
fix(util): add conditional sudo for some install_protoc commands (#117)
0895124
0o-de-lally pushed a commit that referenced this pull request Aug 8, 2024
@nourspace @0o-de-lally
fix(util): add conditional sudo for some install_protoc commands (#117)
ccc9fa2
0o-de-lally pushed a commit that referenced this pull request Aug 8, 2024
@nourspace @0o-de-lally
[util] add conditional sudo for some install_protoc commands (#117)
d734130
0o-de-lally pushed a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 16, 2024
@nourspace @0o-de-lally
fix(util): add conditional sudo for some install_protoc commands (0LN…
e74a56b 
…etworkCommunity#117)
0o-de-lally pushed a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 16, 2024
@nourspace @0o-de-lally
fix(util): add conditional sudo for some install_protoc commands (0LN…
ca3696f 
…etworkCommunity#117)
0o-de-lally pushed a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 16, 2024
@nourspace @0o-de-lally
fix(util): add conditional sudo for some install_protoc commands (0LN…
aff1ea0 
…etworkCommunity#117)
0o-de-lally pushed a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 16, 2024
@nourspace @0o-de-lally
fix(util): add conditional sudo for some install_protoc commands (0LN…
3aa5177 
…etworkCommunity#117)
0o-de-lally pushed a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 16, 2024
@nourspace @0o-de-lally
fix(util): add conditional sudo for some install_protoc commands (0LN…
c14c118 
…etworkCommunity#117)
0o-de-lally pushed a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 17, 2024
@nourspace @0o-de-lally
fix(util): add conditional sudo for some install_protoc commands (0LN…
e3c57c9 
…etworkCommunity#117)
0o-de-lally pushed a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 17, 2024
@nourspace @0o-de-lally
fix(util): add conditional sudo for some install_protoc commands (0LN…
6cb4378 
…etworkCommunity#117)
0o-de-lally pushed a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 17, 2024
@nourspace @0o-de-lally
fix(util): add conditional sudo for some install_protoc commands (0LN…
0fec547 
…etworkCommunity#117)
0o-de-lally pushed a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 17, 2024
@nourspace @0o-de-lally
fix(util): add conditional sudo for some install_protoc commands (0LN…
51bcae3 
…etworkCommunity#117)
0o-de-lally pushed a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 17, 2024
@nourspace @0o-de-lally
[util] add conditional sudo for some install_protoc commands (0LNetwo…
08e22b1 
…rkCommunity#117)
0o-de-lally pushed a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 17, 2024
@nourspace @0o-de-lally
[util] add conditional sudo for some install_protoc commands (0LNetwo…
63930db 
…rkCommunity#117)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hemulin hemulin hemulin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nourspace @hemulin