Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] epoch scheduler #136

Merged

Conversation

0xzoz
Copy link
Contributor

@0xzoz 0xzoz commented Dec 18, 2023

This changes the epoch boundary trigger to a "lazy" pattern. Now, the VM does not execute any functions, since it may abort.

For epoch boundary any end user can call Epoch Trigger when the time is right (Boundary Bit getting set). This moves any abort case to the user, instead of the VM. This is harmless to the user.

This is appropriate for times around upgrades.

@0o-de-lally 0o-de-lally changed the base branch from test-rescue-tx to main December 19, 2023 22:28
@hemulin
Copy link
Contributor

hemulin commented Jan 13, 2024

@0o-de-lally wouldn't it be better (as was proposed in the past), to "piggy back" another process for the epoch change to trigger?

I think this epoch flip tx can be easily automated and put on a cron by multiple nodes, but having self dependency here seems safer.

@0o-de-lally 0o-de-lally force-pushed the epoch_scheduler branch 2 times, most recently from 9be780b to f41c6f0 Compare January 14, 2024 20:16
@0o-de-lally
Copy link
Contributor

0o-de-lally commented Jan 14, 2024

@0o-de-lally wouldn't it be better (as was proposed in the past), to "piggy back" another process for the epoch change to trigger?

Yes. Though the first step is to see how it works with more control, and then we can automate it.

@0o-de-lally 0o-de-lally changed the base branch from main to main-rebase January 15, 2024 20:40
@0o-de-lally 0o-de-lally merged commit 958ce68 into 0LNetworkCommunity:main-rebase Jan 16, 2024
11 of 12 checks passed
0o-de-lally added a commit that referenced this pull request Aug 8, 2024
0o-de-lally added a commit that referenced this pull request Aug 8, 2024
0o-de-lally added a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 16, 2024
0o-de-lally added a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 16, 2024
0o-de-lally added a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 16, 2024
0o-de-lally added a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 16, 2024
0o-de-lally added a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 16, 2024
0o-de-lally added a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 17, 2024
0o-de-lally added a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 17, 2024
0o-de-lally added a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 17, 2024
0o-de-lally added a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 17, 2024
0o-de-lally added a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 17, 2024
0o-de-lally added a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 17, 2024
0o-de-lally added a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants