Skip to content

Commit

Permalink
addressed feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
rachit77 committed Sep 9, 2024
1 parent 74cd236 commit 3d4d4a1
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 3 deletions.
11 changes: 9 additions & 2 deletions .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ linters:
- goconst # Repeated strings that could be replaced by a constant
- forcetypeassert # Finds forced type assertions
- dogsled # Checks assignments with too many blank identifiers (e.g. x, , , _, := f())
# - dupl # Code clone detection
- dupl # Code clone detection
- errname # Checks that sentinel errors are prefixed with the Err and error types are suffixed with the Error
- errorlint # errorlint is a linter for that can be used to find code that will cause problems with the error wrapping scheme introduced in Go 1.13
- gocritic # gocritic is a Go source code linter that maintains checks that are not in other linters
Expand Down Expand Up @@ -75,8 +75,15 @@ issues:
- gosec
- unparam
- lll
- path: 'etherman/contracts/contracts_banana.go'
linters:
- dupl
- path: 'etherman/contracts/contracts_elderberry.go'
linters:
- dupl
include:
- EXC0012 # Exported (.+) should have comment( \(or a comment on this block\))? or be unexported
- EXC0013 # Package comment should be of the form "(.+)...
- EXC0014 # Comment on exported (.+) should be of the form "(.+)..."
- EXC0015 # Should have a package comment
- EXC0015 # Should have a package comment

2 changes: 1 addition & 1 deletion sync/evmdownloader.go
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ func (d *EVMDownloaderImplementation) GetEventsByBlockRange(ctx context.Context,
if b.Hash != l.BlockHash {
d.log.Infof(
"there has been a block hash change between the event query and the block query "+
"for block %d: %s vs %s. Retrtying.",
"for block %d: %s vs %s. Retrying.",
l.BlockNumber, b.Hash, l.BlockHash,
)
return d.GetEventsByBlockRange(ctx, fromBlock, toBlock)
Expand Down

0 comments on commit 3d4d4a1

Please sign in to comment.