feat: removes syncers for aggkit migration #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rachit77
changed the title
* remove aggoracle component * improve Rust build perf and cleanup * handle error when unmarashaling versions.json
* remove aggsender component * fix: remove build-tools
Stefan-Ethernal
force-pushed
the
feat/aggkit-repo-migration
branch
from
79c94e2 to
04b8363
Compare
3 tasks
* mockery generate * Update .mockery.yaml Co-authored-by: Stefan Negovanović <[email protected]> * review comments * review comment --------- Co-authored-by: Stefan Negovanović <[email protected]>
Stefan-Ethernal
force-pushed
the
rachit77/remove-syncers
branch
from
d814581 to
ac8d966
Compare
|
| @@ -276,16 +276,6 @@ RetryAfterErrorPeriod = "1s" | |||
| MaxRetryAttemptsAfterError = -1 | |||
| WaitForNewBlocksPeriod = "3s" | |||
|
|
|||
| [LastGERSync] | |||
There was a problem hiding this comment.
I think we need to discuss about the config we will leave in the cdk repo on the office hours. Maybe it makes sense to remove bunch of stuff.
| "github.com/0xPolygon/cdk/rpc/types" | ||
| tree "github.com/0xPolygon/cdk/tree/types" | ||
| "github.com/agglayer/aggkit/claimsponsor" |
There was a problem hiding this comment.
This might be one more topic to discuss. Should bridge rpc endpoints be left in the cdk or in the aggkit repo.
Stefan-Ethernal
force-pushed
the
feat/aggkit-repo-migration
branch
from
baa4aaa to
7116e38
Compare
|
Should we reuse the following packages from the
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes syncers and other relevant packages for aggkit repo migration