Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cdk-erigon): removed deprecated cdk-erigon config flags #455

Conversation

elliothllm
Copy link

Description

Removing deprecated flags from CDK-Erigon config, they are being removed in the CDK-Erigon kurtoris build workflow and we want to clean it up.

References (if applicable)

https://github.com/0xPolygonHermez/cdk-erigon/blob/zkevm/.github/actions/setup-kurtosis/action.yml

Copy link
Member

@praetoriansentry praetoriansentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we'll merge this without understanding a bit more. Many of the flags that you're removing here are not deprecated.

  • zkevm.disable-virtual-counter this is critical for pessimistic chains
  • zkevm.pool-manager-url this is still in use and critical for production. We still want this in our test setup
  • zkevm.sequencer-batch-seal-time this is not deprecated. This is how we configure the interval at which the sequencer would close batches

I think you can probably clean up the cdk-erigon script independently. I would dry deleting all of those replacements and confirming if it causes any issue

@elliothllm elliothllm closed this Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants