Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Anvil l1 #459

Merged
merged 8 commits into from
Feb 4, 2025
Merged

Anvil l1 #459

merged 8 commits into from
Feb 4, 2025

Conversation

xavier-romero
Copy link
Collaborator

@xavier-romero xavier-romero commented Feb 3, 2025 •
edited
Loading

Description

  • Add option to deploy Anvil as L1
  • Add support (and example/instructions) for restoring L1 state for Anvil
  • Fix small "bug" since Stateless executor was deployed with RPC, after Sequencer, so Sequencer was delaying the whole deployment for 1 minute in strict mode.
  • Minor changes required to support Anvil operation.

@xavier-romero xavier-romero requested a review from leovct February 3, 2025 18:44
@xavier-romero xavier-romero force-pushed the anvil_l1 branch 5 times, most recently from cff5aab to eca8988 Compare February 3, 2025 19:49
leovct
leovct reviewed Feb 4, 2025
View reviewed changes
Copy link
Member

@leovct leovct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just a few nits :)

.github/workflows/deploy.yml Show resolved Hide resolved
anvil.star Show resolved Hide resolved
docs/anvil.md Outdated Show resolved Hide resolved
docs/anvil.md Outdated Show resolved Hide resolved
docs/anvil.md Outdated Show resolved Hide resolved
lib/cdk_erigon.star Outdated Show resolved Hide resolved
leovct
leovct approved these changes Feb 4, 2025
View reviewed changes
Copy link
Member

@leovct leovct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!!!

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 4, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@xavier-romero xavier-romero merged commit ace83c6 into main Feb 4, 2025
33 checks passed
@xavier-romero xavier-romero deleted the anvil_l1 branch February 4, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leovct leovct leovct approved these changes

@praetoriansentry praetoriansentry Awaiting requested review from praetoriansentry praetoriansentry is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xavier-romero @leovct