Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: when PR raised from fork, skip the attach-sovereign-rollup workflow #462

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

jhkimqd
Copy link
Collaborator

@jhkimqd jhkimqd commented Feb 4, 2025

Description

This PR fixes failing attach-sovereign-rollup workflow when an external PR is raised from a fork. The steps depend on the existence of a valid SP1_PRIVATE_KEY, and forked repositories will not have that. This PR skips these steps in such cases.

Signed-off-by: Ji Hwan <[email protected]>
Copy link

sonarqubecloud bot commented Feb 4, 2025

leovct
leovct previously approved these changes Feb 4, 2025
@leovct leovct self-requested a review February 4, 2025 12:50
@leovct leovct dismissed their stale review February 4, 2025 12:50

let's test on a fork first

@leovct leovct merged commit 85f0dc2 into main Feb 4, 2025
32 checks passed
@leovct leovct deleted the jihwan/add-sovereign-rollup-ci-fix branch February 4, 2025 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants