-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CDK Erigon - update overview #1583
Conversation
|
||
## CDK Erigon vs. Erigon | ||
## CDK Erigon vs. standard Erigon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm just wondering if this section is a bit too high level intro to be at the bottom of the page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like you could remove it or reword it and put it further up ... make it a table for easy reading maybe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue with the section (which is what's currently published) is sounds more like marketing than actual facts.
So the idea for this review was to present the facts first, and then help the reader anticipate how these "marketing-like" statements could be true/achievable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
normally you start high level then go deeper, just like headings H1 H2 H3, etc ... the reader will never reach this point probably, and if they do it will read incongruously to them ... my view is a table of differences is much more accessible for the reader and probably should go up top with links to the sections where you elaborate more fully to give the reader the option, and easy navigation to sections they might be interested in ... but that's just my view ...
Co-authored-by: Dra Murphy <[email protected]>
Quality Gate passedIssues Measures |
CDK Erigon - update overview ... as per issue https://polygon.atlassian.net/browse/DOCS-371