Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.4.0 #211

Merged
merged 9 commits into from
Jan 23, 2023
Merged

Release 1.4.0 #211

merged 9 commits into from
Jan 23, 2023

Conversation

cadic
Copy link
Contributor

@cadic cadic commented Jan 6, 2023

Description of the Change

Release and version bump 1.4.0

Closes #210

Verification Process

Verified manually via VS Code

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

@cadic cadic self-assigned this Jan 6, 2023
@cadic cadic added this to the 1.4.0 milestone Jan 6, 2023
@cadic cadic marked this pull request as ready for review January 6, 2023 17:40
@cadic cadic requested a review from jeffpaul January 6, 2023 17:40
jeffpaul
jeffpaul previously approved these changes Jan 6, 2023
Copy link
Member

@jeffpaul jeffpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though one question of whether there are updated (or new) screenshots that should be included with this release?

@jeffpaul
Copy link
Member

jeffpaul commented Jan 6, 2023

I'm fine with handling the release and then coming back after to fix the release dates in CHANGELOG.md and readme.txt with whatever the eventual release date is. No need to re-submit PR for approval just to change those for release.

@cadic
Copy link
Contributor Author

cadic commented Jan 12, 2023

Looks good, though one question of whether there are updated (or new) screenshots that should be included with this release?

According to the changelog, we don't have any breaking changes or new features worth documenting with screenshots.

But in the future update, we definitely want to update screenshots:

  • We now have "Type of show" dropdown, need to be updated on screenshot-3.png
  • We have the "Classic" edit post screen on the screenshot-1.png. Need to add Block Editor screenshot as well (and update classic screenshot to the latest default theme colour palette). Or replace the classic screenshot with the block.

@cadic
Copy link
Contributor Author

cadic commented Jan 12, 2023

Added a new issue #213

@cadic
Copy link
Contributor Author

cadic commented Jan 12, 2023

@jeffpaul I've added last-minute security update and changed the release date, I know it wasn't expected, appreciate your quick review again.

@cadic cadic requested a review from jeffpaul January 12, 2023 10:44
jeffpaul
jeffpaul previously approved these changes Jan 12, 2023
Copy link
Member

@jeffpaul jeffpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks for handling the release!

@Sidsector9 Sidsector9 merged commit a940466 into develop Jan 23, 2023
@Sidsector9 Sidsector9 deleted the release/1.4.0 branch January 23, 2023 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release 1.4.0
3 participants