Skip to content
This repository has been archived by the owner on Mar 15, 2024. It is now read-only.

Update nginx-proxy to latest upstream, support multiple architectures #22

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dustinrue
Copy link
Collaborator

Description of the Change

  • Updated to use latest upstream proxy version
  • Updated certs to satisfy requirements of updated upstream version
  • Can be built for multiple architectures (see readme)

Alternate Designs

Benefits

Possible Drawbacks

Verification Process

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

Changelog Entry

@dustinrue
Copy link
Collaborator Author

This PR would close #21

@@ -1,4 +1,4 @@
FROM jwilder/nginx-proxy:0.7.0
FROM nginxproxy/nginx-proxy:latest
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dustinrue jwilder/nginx-proxy also supports arm based systems now:
hub docker com_search_q=jwilder%2Fnginx-proxy type=image

Looks like we don't need to switch to nginxproxy/nginx-proxy anymore, do we? We just need to update the tag of the jwilder/nginx-proxy image. I think we can even update it to the alpine tag which is 3 times smaller than the latest one. What do you think?

Suggested change
FROM nginxproxy/nginx-proxy:latest
FROM jwilder/nginx-proxy:alpine

@jeffpaul jeffpaul requested a review from darylldoyle February 15, 2024 21:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants