-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kharidian Desert Overhaul #544
base: master
Are you sure you want to change the base?
Conversation
[ 3266, 3262, 0, 3269, 3263, 0 ], | ||
[ 3275, 3294, 0, 3275, 3295, 0 ], | ||
[ 3292, 3328, 0, 3300, 3329, 0 ] | ||
[ 3348, 3293, 3415, 3329 ], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of these served no logical purpose. another i extended to correct an overworld bug.
Arguably could be renamed to "Mage Training Arena Grass" as short of the one fix that is all it is at this point.
The Alkarid mine walls are a bit green in your screenshots so ive come up with whats below: not sure how to submit an actual change to a pull request so ill just paste the change below and you can implement it
Overall though this PR is a fantastic fix |
Looks nice I do agree with Jin tho the walls are a little green |
I didn't hue shift those walls leaving them the vanilla default. Whoops! 😅 |
fixed :) |
Scope:
Upgrade Kharidian region to better reflect the vanilla visual styles while fixing blending issues, ensuring Winter theme is disregarded within the region as; it clearly wouldn't be snowing there, and general ugliness correction.
Reason:
117 did not have the tools we have not to do proper tile sorting and texturing based on HSL values and locked the sand to a single color, hue and saturation to resolve horrible brightness problems as well as mixed up grass\sand\dirt textures in the desert and on its borders.
Technical notes:
Comparisons:
Vanilla\Current\Proposed: