Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object Light Adjustments #548

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Jin-Jiyunsun
Copy link
Contributor

The goal of this pull request is to adjust some of the common lights such as wall torches and lanterns to be more accurate to their source and to try and tackle light bleed by adjusting their parameters.

image
image

image
image

image
image

image
image

…nd more accurate to their source

- Adjust some textures on light emitting objects
@SirFancyBacon
Copy link
Contributor

love how you split out those objects; it will make editing in the future so much easier.
all in all i like the change;

Something to note:
Juliets Wall Torch is shared with the Varrock clothing store; so the light is floating outside behind the building; Better that imho versus not having them correct in Juliets house.

This is present in Master and shouldn't be considered a merge blocker imho

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants