Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix active hover state for navigation section #419

Merged
merged 1 commit into from
Mar 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@
- Add missing JavaScript exports for `button`, `inPageNavigation`, `inputMask`, `languageSelector`, and `range`. ([#407](https://github.com/18F/identity-design-system/pull/407))
- Fix `dist/assets/js/main.js` compilation to properly consider browser support. ([#421](https://github.com/18F/identity-design-system/pull/421))
- Fix strict ES Module import errors due to lack of fully-qualified file path when importing `auto` entrypoint. ([#422](https://github.com/18F/identity-design-system/pull/422))
- Fix background color when hovering an expanded navigation section on large viewport sizes. ([#418](https://github.com/18F/identity-design-system/pull/418))

### Internal

Expand Down
8 changes: 5 additions & 3 deletions src/scss/packages/usa-nav/src/_overrides.scss
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,11 @@
}
}

button {
&:hover {
background-color: color('primary-lightest');
@include at-media-max($theme-header-min-width) {
button {
&:hover {
background-color: color('primary-lightest');
}
}
}
}
Expand Down
Loading