Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update styling for Tag component for consistency with USWDS #426

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Update styling for Tag component for consistency with USWDS #426

merged 1 commit into from
Mar 15, 2024

Conversation

aduth
Copy link
Member

@aduth aduth commented Mar 15, 2024

🛠 Summary of changes

Removes some styling overrides from the Tag component for consistency with USWDS:

  • Remove border radius override, reducing radius from 0.25rem (4px) to 0.125rem (2px)
  • Remove bold styling override, reverting to normal font size

📜 Testing Plan

  1. Run the application locally: npm start
  2. Go to http://localhost:4000/tags/
  3. Observe visual appearance of tags

👀 Screenshots

Before After
image image

@aduth aduth requested a review from nickttng March 15, 2024 14:21
@aduth
Copy link
Member Author

aduth commented Mar 15, 2024

Visual regression failure is expected for the impacted style revisions.

image

@aduth aduth merged commit 7f0720d into main Mar 15, 2024
3 of 4 checks passed
@aduth aduth deleted the aduth-tag-styling-uswds branch March 15, 2024 14:48
@aduth aduth mentioned this pull request Mar 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickttng nickttng nickttng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aduth @nickttng