Remove nav container from header component example #430
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Improves header component markup example to avoid
<div class="usa-nav-container">
. It also updates the logo link to always point to the root regardless of{{ site.baseurl }}
value (previously it would often link to the same page).Why?
identity-site
, but the default USWDS component guidance for extended header does not include itusa-nav-container
creates additional horizontal padding that causes it to be misaligned with page content that includes navigation📜 Testing Plan
Easiest to review with whitespace changes hidden, since the changes amount to removing a single wrapper element
<div class="usa-nav-container">
.npm start
👀 Screenshots