-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI Pipeline Runs example/example.py #151
base: main
Are you sure you want to change the base?
Conversation
…ith parameters of created item. example.py reads vault id from env var. Call to run example.py added to pipeline
…or. Edited GitHub Secret names to match.
If you're new to commit signing, there are different ways to set it up: Sign commits with
|
df40bab
to
337ab76
Compare
337ab76
to
03e4e6e
Compare
…r read from environment variables
@@ -35,7 +36,15 @@ jobs: | |||
pip install pytest-asyncio && | |||
pip install pydantic && | |||
python -m pytest src/onepassword/test_client.py | |||
|
|||
- name: Example Test | |||
if: matrix.os == 'ubuntu-latest' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same with Go comment, we are running this on 4 different python versions (should be 6 with 3.13 and 3.14) and will run 6 jobs on ubuntu running the example code still increasing the chances of a 409. We want to split this into a separate job and just run it on ubuntu and on a singular python version
- name: Example Test | ||
env: | ||
OP_SERVICE_ACCOUNT_TOKEN: ${{ secrets.TEST_SERVICE_ACCOUNT_TOKEN }} | ||
OP_VAULT_ID: ${{ secrets.TEST_SERVICE_ACCOUNT_VAULT_ID }} | ||
run: | | ||
pip install . && | ||
python example/example.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same with above
Altered logic in
example/example.py
to read the previously hardcodedvault_id
from environment variables.Added
example/example.py
to the validation workflow, and readOP_SERVICE_ACCOUNT_TOKEN
andOP_VAULT_ID
from GitHub secrets.Altered the example
client.secrets.resolve
to resolve field from item created during theexample.py
item CRUD.