Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix writing enum values in Go #233

Merged
merged 2 commits into from
Feb 28, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions core/data/tests/anonymous_struct_with_rename/output.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@ type AnonymousStructWithRenameKebabCaseInner struct {
}
type AnonymousStructWithRenameTypes string
const (
AnonymousStructWithRenameTypeVariantList AnonymousStructWithRenameTypes = "List"
AnonymousStructWithRenameTypeVariantLongFieldNames AnonymousStructWithRenameTypes = "LongFieldNames"
AnonymousStructWithRenameTypeVariantKebabCase AnonymousStructWithRenameTypes = "KebabCase"
AnonymousStructWithRenameTypeVariantList AnonymousStructWithRenameTypes = "list"
AnonymousStructWithRenameTypeVariantLongFieldNames AnonymousStructWithRenameTypes = "longFieldNames"
AnonymousStructWithRenameTypeVariantKebabCase AnonymousStructWithRenameTypes = "kebabCase"
)
type AnonymousStructWithRename struct{
Type AnonymousStructWithRenameTypes `json:"type"`
Expand Down
8 changes: 4 additions & 4 deletions core/data/tests/can_generate_algebraic_enum/output.go
Original file line number Diff line number Diff line change
Expand Up @@ -121,11 +121,11 @@ func NewAdvancedColorsTypeVariantReallyCoolType(content *ItemDetailsFieldValue)
type AdvancedColors2Types string
const (
// This is a case comment
AdvancedColors2TypeVariantString AdvancedColors2Types = "String"
AdvancedColors2TypeVariantNumber AdvancedColors2Types = "Number"
AdvancedColors2TypeVariantNumberArray AdvancedColors2Types = "NumberArray"
AdvancedColors2TypeVariantString AdvancedColors2Types = "string"
AdvancedColors2TypeVariantNumber AdvancedColors2Types = "number"
AdvancedColors2TypeVariantNumberArray AdvancedColors2Types = "number-array"
// Comment on the last element
AdvancedColors2TypeVariantReallyCoolType AdvancedColors2Types = "ReallyCoolType"
AdvancedColors2TypeVariantReallyCoolType AdvancedColors2Types = "really-cool-type"
)
type AdvancedColors2 struct{
Type AdvancedColors2Types `json:"type"`
Expand Down
2 changes: 1 addition & 1 deletion core/data/tests/can_handle_unit_type/output.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ type StructHasVoidType struct {
// This enum has a variant associated with unit data
type EnumHasVoidTypeTypes string
const (
EnumHasVoidTypeTypeVariantHasAUnit EnumHasVoidTypeTypes = "HasAUnit"
EnumHasVoidTypeTypeVariantHasAUnit EnumHasVoidTypeTypes = "hasAUnit"
)
type EnumHasVoidType struct{
Type EnumHasVoidTypeTypes `json:"type"`
Expand Down
12 changes: 6 additions & 6 deletions core/data/tests/recursive_enum_decorator/output.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@ type MoreOptionsBuiltInner struct {
}
type MoreOptionsTypes string
const (
MoreOptionsTypeVariantNews MoreOptionsTypes = "News"
MoreOptionsTypeVariantExactly MoreOptionsTypes = "Exactly"
MoreOptionsTypeVariantBuilt MoreOptionsTypes = "Built"
MoreOptionsTypeVariantNews MoreOptionsTypes = "news"
MoreOptionsTypeVariantExactly MoreOptionsTypes = "exactly"
MoreOptionsTypeVariantBuilt MoreOptionsTypes = "built"
)
type MoreOptions struct{
Type MoreOptionsTypes `json:"type"`
Expand Down Expand Up @@ -94,9 +94,9 @@ func NewMoreOptionsTypeVariantBuilt(content *MoreOptionsBuiltInner) MoreOptions

type OptionsTypes string
const (
OptionsTypeVariantRed OptionsTypes = "Red"
OptionsTypeVariantBanana OptionsTypes = "Banana"
OptionsTypeVariantVermont OptionsTypes = "Vermont"
OptionsTypeVariantRed OptionsTypes = "red"
OptionsTypeVariantBanana OptionsTypes = "banana"
OptionsTypeVariantVermont OptionsTypes = "vermont"
)
type Options struct{
Type OptionsTypes `json:"type"`
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@ type ItemDetailsFieldValue struct {
}
type AdvancedColorsTypes string
const (
AdvancedColorsTypeVariantString AdvancedColorsTypes = "String"
AdvancedColorsTypeVariantNumber AdvancedColorsTypes = "Number"
AdvancedColorsTypeVariantNumberArray AdvancedColorsTypes = "NumberArray"
AdvancedColorsTypeVariantReallyCoolType AdvancedColorsTypes = "ReallyCoolType"
AdvancedColorsTypeVariantString AdvancedColorsTypes = "string"
AdvancedColorsTypeVariantNumber AdvancedColorsTypes = "number"
AdvancedColorsTypeVariantNumberArray AdvancedColorsTypes = "number-array"
AdvancedColorsTypeVariantReallyCoolType AdvancedColorsTypes = "reallyCoolType"
)
type AdvancedColors struct{
Type AdvancedColorsTypes `json:"type"`
Expand Down
2 changes: 1 addition & 1 deletion core/src/language/go.rs
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,7 @@ impl Go {
"\t{} {} = {:?}",
variant_type_const,
variant_key_type,
&v.shared().id.original
&v.shared().id.renamed
)?;
}

Expand Down
Loading