Allow PUT and PATCH method for upload route #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giosh94mhz
force-pushed
the
allow_put_patch
branch
from
f6e46ba to
3f31f33
Compare
|
I forgot to fix the tests. Now everything should pass (in both commit). |
giosh94mhz
force-pushed
the
allow_put_patch
branch
from
3f31f33 to
d60f1ae
Compare
sheeep
pushed a commit
that referenced
this pull request
Mar 11, 2015
Allow PUT and PATCH method for upload route
Me neither, but |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default routing strategy allow only
POSTas HTTP verb to upload files, butPUTis actually better for RESTful interfaces. For completeness, I've added alsoPATCH, which may be used when upload of file will alter existing resources.While I was at it, I've removed deprecated use of
_requirementsfor setting_methods; this will become a BC in symfony 3.0, so if this branch is not merged you can cherry-pick that commit.This PR relate to issue #118 , and probably the two are mutually exclusive. Anyway, I cannot understand why and how one would use
GET...