fixed an error in query and test assertion

2amigos · Apr 15, 2024 · f6e3b27 · f6e3b27
1 parent 3e7e4b0
commit f6e3b27
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/Queue/Backend/Pdo/PdoQueueStoreAdapter.php b/src/Queue/Backend/Pdo/PdoQueueStoreAdapter.php
@@ -115,7 +115,7 @@ public function ack(MailJobInterface $mailJob)
 
         $mailJob->incrementAttempt();
         if($mailJob->getAttempt() > $config['max-attempts']){
-            $sqlText = 'DELETE FROM mail_queue WHERE id = :max_attempt;';
+            $sqlText = 'DELETE FROM mail_queue WHERE id = :id;';
             $sql = sprintf($sqlText, $this->tableName);
             $query = $this->getConnection()->getInstance()->prepare($sql);
             $query->bindValue(':id', $mailJob->getId());

diff --git a/tests/Queue/Backend/Pdo/PdoQueueStoreAdapterTest.php b/tests/Queue/Backend/Pdo/PdoQueueStoreAdapterTest.php
@@ -63,7 +63,7 @@ public function testAcknowledgementToUpdateMailJobs()
         $dequedMailJob->markAsNew();
         $this->pdoQueueStore->ack($dequedMailJob);
         sleep(1);
-        $this->assertTrue($this->pdoQueueStore->isEmpty() === false);
+        $this->assertTrue($this->pdoQueueStore->isEmpty() === true);
     }
 
     public function testBadMethodCallExceptionOnAck()