Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tarfile security issue #457

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Conversation

Gustry
Copy link
Member

@Gustry Gustry commented Aug 7, 2024

Superseeds #434 for all Python version

@Gustry Gustry requested a review from dmarteau August 7, 2024 13:12
@Gustry Gustry mentioned this pull request Aug 7, 2024
Copy link
Member

@dmarteau dmarteau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A wrong test and a minor typo.

cadastre/cadastre_import.py Outdated Show resolved Hide resolved
cadastre/cadastre_import.py Outdated Show resolved Hide resolved
@Gustry Gustry force-pushed the python-version-tar branch 3 times, most recently from 94998ad to 1a54cdf Compare August 8, 2024 09:08
@Gustry
Copy link
Member Author

Gustry commented Aug 8, 2024

Thanks for the review @dmarteau

OK for you ?

Copy link
Member

@dmarteau dmarteau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
J'aurais peut-être mis un message plus explicite en justifiant la mise à jour par l'existence d'une faille de sécurité, comme ça les utilisateurs sont plus enclins à upgrader.

@Gustry Gustry merged commit 05a40c2 into 3liz:master Aug 9, 2024
2 checks passed
@Gustry Gustry deleted the python-version-tar branch August 9, 2024 08:32
@landryb
Copy link
Contributor

landryb commented Aug 20, 2024

J'aurais peut-être mis un message plus explicite en justifiant la mise à jour par l'existence d'une faille de sécurité, comme ça les utilisateurs sont plus enclins à upgrader.

je ne sais pas bien comment ca fonctionne sous windows, mais il me semble que les utilisateurs n'ont pas forcément le choix de la version de python bundlée avec leur installation de QGIS .. non ? et ils ne savent probablement pas ce qu'est python non plus :)

@Gustry
Copy link
Member Author

Gustry commented Aug 20, 2024

Oui, entièrement d'accord. C'est pour ca que je ne voulais pas passer du temps de dessus, voir la discussion dans le PR précédent #434 ;-)

Quasi 50% des utilisateurs de Cadastre sont en Python 3.9.5 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants