-
-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructuration package.json #5303
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice cleanup !
- Can you edit the
INSTALL.md
about building JS ? - We need to look the
make build
command, to add the optionnpm install --production
to not install dev dependancies in production packages
a5c28f1
to
920052f
Compare
2e0435b
to
173e852
Compare
7ac7324
to
1c642df
Compare
3acf2f4
to
d8126b4
Compare
41abced
to
db6fb8e
Compare
db6fb8e
to
ce696b9
Compare
The backport to
stderr
stdout
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release_3_8 release_3_8
# Navigate to the new working tree
cd .worktrees/backport-release_3_8
# Create a new branch
git switch --create backport-5303-to-release_3_8
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick 1c642dff7fce827949335a27309e140eca2d288a,88f12c088fcd1da8aba6cddd2f0df1586a392b55,58954f1919146c732e8536b378be8df61618c164,d8126b4b1d5916451caf8cd55584a34c9b42128a,874e6feaf98870492777852fa38eb4925290d124,ce696b9e48ebb34ac19dad5bc716339463689b98
# Push it to GitHub
git push --set-upstream origin backport-5303-to-release_3_8
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release_3_8 Then, create a pull request where the |
The backport to
stderr
stdout
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release_3_9 release_3_9
# Navigate to the new working tree
cd .worktrees/backport-release_3_9
# Create a new branch
git switch --create backport-5303-to-release_3_9
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick 1c642dff7fce827949335a27309e140eca2d288a,88f12c088fcd1da8aba6cddd2f0df1586a392b55,58954f1919146c732e8536b378be8df61618c164,d8126b4b1d5916451caf8cd55584a34c9b42128a,874e6feaf98870492777852fa38eb4925290d124,ce696b9e48ebb34ac19dad5bc716339463689b98
# Push it to GitHub
git push --set-upstream origin backport-5303-to-release_3_9
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release_3_9 Then, create a pull request where the |
Changes how package.json are structured in LWC
package.json
with workspacespackage.json
are linked to the main onenpm install
is required to install all dependencies at the same locationnpm run js:test
inLWC/tests/js-units
can be executed inLWC/
withnpm run js:test --workspace=tests/js:test
import
path for js unit testsFunded by 3Liz