UX - Display an error message if the layer is not found in the CFG file, if admin

[Gustry]

I'm keen to have some feedbacks here.

For now, globally in Lizmap, if an error occurs, there is nothing displayed in the user interface. The only way is to open the developer tools, which is not a good advice, our admin end-users shouldn't open the web developer tools.

It would be nice, at the end of loading a map, a UI box is displayed if there were any "error" during loading the map ?

Just to keen to have ideas

[mdouchin]

Nice catch. Minor rephrasing needed IMHO

[Gustry]

I'm keen to have feedbacks about this document variable @nboisteault and @rldhont
https://www.geeksforgeeks.org/how-to-fix-referenceerror-document-is-not-defined-in-javascript/

I didn't look too much

[nboisteault]

I'm keen to have feedbacks about this document variable @nboisteault and @rldhont https://www.geeksforgeeks.org/how-to-fix-referenceerror-document-is-not-defined-in-javascript/

I didn't look too much

Where is the issue?

[Gustry]

Where is the issue?

document is not defined, as described in the code, just check what I have done

[Gustry]

@rldhont I have no idea what I have done, just to test for now.

I need to check where to call the invalidLayersNotFoundInCfg and add the :

const errorMessage = `The WMS layer name "${wmsName}" is unknown. Is the Lizmap configuration file "${lizUrls.params.project}.qgs.cfg" up to date ?`;
console.error(errorMessage);
if (document.body.dataset.lizmapAdminUser === 1) {
   lizMap.addMessage(errorMessage, 'warning', true).attr('id', 'lizmap-warning-message');
} else {
   // Display a nicer messager saying this map has some technical issues
}

[rldhont]

I prefered to have this API

export function buildLayerTreeConfig(wmsCapaLayerRoot, layersCfg, invalid = []) {
        const items = buildLayerTreeGroupConfigItems(wmsCapaLayerRoot, layersCfg, 0, invalid);
       return new LayerTreeGroupConfig('root', 0, items, wmsCapaLayerRoot);
}

function buildLayerTreeGroupConfigItems(wmsCapaLayerGroup, layersCfg, level, invalid = []) {
    ...
    return items;
}
    get layerTree() {
        if (this._layerTree == null) {
            this._invalid_layers = []; 
            this._layerTree = buildLayerTreeConfig(this._theWmsCapabilities.Capability.Layer, this.layers, this._invalid_layers);
        }
        return this._layerTree;
    }