Fix: handle unused-result warning during compilation #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As students of 42, when compiling our projects, we strive to maintain a clean output free of errors or warnings. In projects that use minilibx-linux, certain warnings may appear that are beyond our control, but it is still valuable to address them for clarity and presentation. For this reason, I made a small modification by adding the -Wno-unused-result flag to the Makefile.mk.
I understand that for the development and maintenance of this library, controlling unused variables is essential. However, as a library distribution used in 42 projects, these warnings may impact the perceived quality of both the library and the students' projects that rely on it. For this reason, I believe this small contribution could be considered helpful.
Thank you very much!