Skip to content

Commit

Permalink
Update post types and include system removals in skip logic (mattermo…
Browse files Browse the repository at this point in the history
…st) (#2125)
  • Loading branch information
NeilHanlon authored May 23, 2024
1 parent fa147c0 commit 6b528ff
Showing 1 changed file with 15 additions and 3 deletions.
18 changes: 15 additions & 3 deletions bridge/mattermost/helpers.go
Original file line number Diff line number Diff line change
Expand Up @@ -171,12 +171,24 @@ func (b *Bmattermost) sendWebhook(msg config.Message) (string, error) {
}

// skipMessages returns true if this message should not be handled
//
//nolint:gocyclo,cyclop
func (b *Bmattermost) skipMessage(message *matterclient.Message) bool {

// Handle join/leave
if message.Type == "system_join_leave" ||
message.Type == "system_join_channel" ||
message.Type == "system_leave_channel" {
skipJoinMessageTypes := map[string]struct{}{
"system_join_leave": {}, //deprecated for system_add_to_channel
"system_leave_channel": {}, //deprecated for system_remove_from_channel
"system_join_channel": {},
"system_add_to_channel": {},
"system_remove_from_channel": {},
"system_add_to_team": {},
"system_remove_from_team": {},
}

// dirty hack to efficiently check if this element is in the map without writing a contains func
// can be replaced with native slice.contains with go 1.21
if _, ok := skipJoinMessageTypes[message.Type]; ok {
if b.GetBool("nosendjoinpart") {
return true
}
Expand Down

0 comments on commit 6b528ff

Please sign in to comment.