Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Fix two panics #10

Merged
merged 2 commits into from
May 2, 2024
Merged

fix(core): Fix two panics #10

merged 2 commits into from
May 2, 2024

Conversation

anurag-rajawat
Copy link
Contributor

@anurag-rajawat anurag-rajawat commented Mar 28, 2024

Description

This PR fix panics due to interface conversion and ai handler in the sentryflow, resolving crash.

sentryflow-clients/.gitignore Outdated Show resolved Hide resolved
Copy link
Contributor

@VedRatan VedRatan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VedRatan
Copy link
Contributor

@anurag-rajawat it would be good if you could resolve the conflicts.

@anurag-rajawat anurag-rajawat marked this pull request as draft April 16, 2024 03:12
@anurag-rajawat anurag-rajawat marked this pull request as ready for review April 16, 2024 09:43
@anurag-rajawat anurag-rajawat marked this pull request as draft April 16, 2024 09:50
Signed-off-by: Anurag Rajawat <[email protected]>
@anurag-rajawat anurag-rajawat marked this pull request as ready for review April 17, 2024 12:54
@anurag-rajawat anurag-rajawat changed the title fix(core): Fix Panic due to interface conversion fix(core): Fix two panics Apr 17, 2024
@anurag-rajawat anurag-rajawat requested review from shivaccuknox and VedRatan and removed request for isu-kim May 2, 2024 03:38
Copy link
Contributor

@VedRatan VedRatan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VedRatan VedRatan merged commit 579a723 into main May 2, 2024
8 checks passed
@anurag-rajawat anurag-rajawat deleted the fixes branch May 2, 2024 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants