Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat): Add Fluent-bit to K8tls #233

Conversation

JonesJefferson
Copy link
Contributor

@JonesJefferson JonesJefferson commented Aug 4, 2024

Description

Changes to helm of nimbus-k8tls and numbus-k8tls adapter to support sending k8tls reports using fluent-bit. It will be sent to stdout of fluent-bit by default. If elasticsearch is enabled in helm values file, then it will be sent to elasticsearch.

Fixes #223

Does this PR introduce a breaking change?

Checklist

  • PR title follows the <type>: <description> convention
  • I use conventional commits in my commit messages
  • I have updated the documentation accordingly
  • I Keep It Small and Simple: The smaller the PR is, the easier it is to review and have it merged
  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Additional information for reviewer

Mention if this PR is part of any design or a continuation of previous PRs

Fluent bit logs

Screenshot 2024-08-05 at 3 01 43 AM

Working example

https://www.loom.com/share/e99311c4757444f4aafe22ea372cbf62?sid=5113fd0b-ba9e-4b49-9580-8aec4abc51c3

@JonesJefferson JonesJefferson force-pushed the feat/issue-218-add-fluent-bit-to-k8tls branch 2 times, most recently from df2ba29 to 127ae54 Compare August 5, 2024 09:43
@JonesJefferson JonesJefferson marked this pull request as ready for review August 5, 2024 09:44
@nandhued nandhued linked an issue Aug 6, 2024 that may be closed by this pull request
@JonesJefferson JonesJefferson force-pushed the feat/issue-218-add-fluent-bit-to-k8tls branch from 127ae54 to be0003b Compare August 6, 2024 08:48
Signed-off-by: Jones Jefferson <[email protected]>
@JonesJefferson JonesJefferson force-pushed the feat/issue-218-add-fluent-bit-to-k8tls branch from be0003b to 844868e Compare August 6, 2024 08:51
deployments/nimbus-k8tls/templates/daemonset.yaml Outdated Show resolved Hide resolved
pkg/adapter/nimbus-k8tls/manager/manager.go Outdated Show resolved Hide resolved
pkg/adapter/nimbus-k8tls/manager/manager.go Outdated Show resolved Hide resolved
pkg/adapter/nimbus-k8tls/builder/builder.go Outdated Show resolved Hide resolved
pkg/adapter/nimbus-k8tls/builder/builder.go Outdated Show resolved Hide resolved
pkg/adapter/nimbus-k8tls/builder/builder.go Outdated Show resolved Hide resolved
pkg/adapter/nimbus-k8tls/builder/builder.go Show resolved Hide resolved
@JonesJefferson JonesJefferson force-pushed the feat/issue-218-add-fluent-bit-to-k8tls branch from 90986c8 to 48e0e05 Compare August 14, 2024 03:00
Signed-off-by: Jones Jefferson <[email protected]>
@JonesJefferson JonesJefferson force-pushed the feat/issue-218-add-fluent-bit-to-k8tls branch from 48e0e05 to c67b00c Compare August 14, 2024 03:40
@anurag-rajawat anurag-rajawat removed a link to an issue Aug 14, 2024
Copy link
Collaborator

@anurag-rajawat anurag-rajawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, rebase and we're good to merge it.

@anurag-rajawat anurag-rajawat merged commit 9476d9e into 5GSEC:main Aug 14, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

k8tls reporter
3 participants