(feat):Kyverno Adapter #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
VedRatan
force-pushed
the
issue_76
branch
7 times, most recently
from
0098de3 to
f2e37cf
Compare
|
In a follow-up PR add a helm chart and include this in our release adapters and adapter images build jobs: https://github.com/5GSEC/nimbus/tree/main/deployments nimbus/.github/workflows/latest-release.yaml Lines 33 to 34 in b91563b nimbus/.github/workflows/pr-checks.yaml Lines 85 to 86 in b91563b |
|
@anurag-rajawat I have addressed all your reviews. |
|
On running make from root directory I'm getting the below error: ❯ make
/Users/anurag/projects/work/nimbus/bin/controller-gen rbac:roleName=nimbus-operator crd webhook paths="./..." output:crd:artifacts:config=config/crd/bases
Error: load packages in root "/Users/anurag/projects/work/nimbus/pkg/adapter/nimbus-kyverno": err: exit status 1: stderr: go: github.com/emicklei/go-restful/[email protected]: missing go.sum entry for go.mod file; to add it:
go mod download github.com/emicklei/go-restful/v3Please update the dependencies by executing the below command from the kyverno-adapter directory: go mod tidy |
|
Please address this comment. |
Signed-off-by: Ved Ratan <[email protected]> updated adapter for namespaced policy Signed-off-by: Ved Ratan <[email protected]> added clusterpolicy logic Signed-off-by: Ved Ratan <[email protected]> minor fixes Signed-off-by: Ved Ratan <[email protected]>
|
@anurag-rajawat I had addressed your comments, I guess we are good to merge this one. |
Signed-off-by: Anurag Rajawat <[email protected]>
anurag-rajawat
force-pushed
the
issue_76
branch
from
e389233 to
8ff8d17
Compare
anurag-rajawat
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new kyverno adapter for escapeToHost issue.Fixes # (issue)
Closes #76
Does this PR introduce a breaking change?
Checklist
<type>: <description>conventionAdditional information for reviewer
Mention if this PR is part of any design or a continuation of previous PRs