Support existingSecret for redis configuration #81
Conversation
| @@ -280,6 +280,8 @@ scaling: | |||
| redis: | |||
| host: | |||
| password: | |||
| existingSecret: | |||
There was a problem hiding this comment.
Can you uncomment those two lines, as they are optional.
Also you can add a comment above explaining the purpose of those two entries.
|
Is there any progress with this merger? This feature is highly appreciated. |
yes, see #81 (review) |
So @sebastiansterk are you able to set the commenting? |
WalkthroughThe pull request introduces additional configuration options for Redis secret management within the Helm chart. Two new fields, Changes
Sequence Diagram(s)sequenceDiagram
participant U as User
participant H as Helm Chart Renderer
participant T as Template Engine
participant K as Kubernetes Cluster
U->>H: Provide Redis secret configuration values
H->>T: Process Helm templates with the new secret fields
Note right of T: Check if 'existingSecret' and 'existingSecretPasswordKey' are provided
T->>T: Set 'QUEUE_BULL_REDIS_PASSWORD' environment variable based on secret lookup
T->>K: Deploy updated configuration to Kubernetes
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
README.md (1)
283-284: Add descriptions for the new Redis secret configuration options.To improve documentation, add descriptions explaining the purpose of these fields and their relationship with the Bitnami Redis chart.
Apply this diff:
- existingSecret: - existingSecretPasswordKey: + existingSecret: # Name of the existing Kubernetes secret containing the Redis password + existingSecretPasswordKey: # Key in the existing secret that contains the Redis password
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
README.md(1 hunks)templates/_helpers.tpl(1 hunks)values.yaml(1 hunks)
🔇 Additional comments (2)
templates/_helpers.tpl (1)
95-101: LGTM! Well-structured implementation for Redis secret management.The implementation correctly follows Kubernetes best practices for secret management and maintains consistency with other secret references in the file.
values.yaml (1)
324-325: Add documentation and uncomment the optional fields.Based on previous review feedback, please:
- Add a comment explaining the purpose of these fields
- Uncomment the fields as they are optional configurations
Apply this diff:
- # existingSecret: - # existingSecretPasswordKey: + # Use an existing Kubernetes secret for Redis password + existingSecret: + existingSecretPasswordKey:
|
I am closing this PR as these changes have now been added into the main branch. |
Introduces scaling.redis.existingSecret and scaling.redis.existingSecretKey to enable referencing an existing secret containing the Redis password. This aligns with the Bitnami Redis chart, allowing both to use the same secret.
Summary by CodeRabbit