Flash attention for GPUs like in maxtext #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksikiric
force-pushed
the
kris/flux-FA
branch
from
7b6ee9d to
350026b
Compare
|
@ksikiric tested this and looks great. Added a few comments, once resolved this should be ready to merge into main. Please rebase with main and run |
… Start creating generation code for flux.
ksikiric
force-pushed
the
kris/flux-FA
branch
from
350026b to
3141d69
Compare
|
@ksikiric let me know when you can take a look at the latest comments. This is very close to being ready! :) |
|
@entrpn I can't see any other comments than the ones I have already marked as resolved, are there any other comments that I am missing? |
entrpn
reviewed
Feb 19, 2025
|
@ksikiric my bad, forgot to click the button. Take a look and let me know if you see them now. |
|
@entrpn I fixed those comments now! |
entrpn
reviewed
Feb 20, 2025
entrpn
approved these changes
Feb 21, 2025
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #147
Adding FA support for GPUs using TransformerEngine, same as in maxtext. These changes are added on top of #147, which has been rebased on flux_lora as per #148.