Get all tests to pass locally with no special configuration #1108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamuelMarks
requested review from
gobbleturk,
khatwanimohit,
bvandermoon and
vipannalla
as code owners
|
The grain issue might be solved by #1109 |
|
Good to see. Also related is your recent PR #1113 |
|
Hi @SamuelMarks sorry for the delay! Do you have time to update the PR so we can merge it ? New tests might have been added (in particular some integration tests). |
# Conflicts: # MaxText/tests/attention_test.py # MaxText/tests/hf_data_processing_test.py # MaxText/tests/inference_microbenchmark_smoke_test.py # MaxText/tests/maxengine_test.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
FIXES: #1107
Tests
python -m pytestandpytestshould both now work when run from repository root.Checklist
Before submitting this PR, please make sure (put X in square brackets):
Important: do not merge yet! - I want to solve your grain issue [ https://github.com/AI-Hypercomputer/maxtext/actions/runs/12421511705/job/34681866302 ] first; which I think this commit fixed google/grain@ce66a97...08f7cb1
EDIT: Can you ping the guys? - Looks like they just need to release anew google/grain/issues/662