Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DeepSeek rollout checkpoint generation #1337

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

DeepSeek rollout checkpoint generation #1337

wants to merge 2 commits into from
+44 −34

Conversation

gagika
Copy link
Collaborator

@gagika gagika commented Mar 3, 2025

Description

Deepseek rollout checkpoint generation

Fix for unscanned forward pass.

Tests

Tested both changes, generate_params and unscanned DeepSeek forward pass

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed.

RissyRan
RissyRan approved these changes Mar 3, 2025
View reviewed changes
Copy link
Collaborator

@RissyRan RissyRan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for separating those in unscanned ckpt!

This will also address this issue. I will mark this as duplicate.

This was referenced Mar 3, 2025
Open
Closed
@gagika
DeepSeek rollout checkpoint generation
afb6c0f 
fix pyink

reduce number of positinal arguments

make unroll_layer_group as inner function.

Skip test_moe_deepseek_unscanned_bf16 test
@gagika gagika force-pushed the agagik-ds-rollout branch from af00004 to afb6c0f Compare March 6, 2025 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RissyRan RissyRan RissyRan approved these changes

@gobbleturk gobbleturk gobbleturk approved these changes

@khatwanimohit khatwanimohit Awaiting requested review from khatwanimohit khatwanimohit is a code owner

@bvandermoon bvandermoon Awaiting requested review from bvandermoon bvandermoon is a code owner

@vipannalla vipannalla Awaiting requested review from vipannalla vipannalla is a code owner

@richjames0 richjames0 Awaiting requested review from richjames0 richjames0 is a code owner

@rni418 rni418 Awaiting requested review from rni418 rni418 is a code owner

@shralex shralex Awaiting requested review from shralex shralex is a code owner

@yangyuwei yangyuwei Awaiting requested review from yangyuwei yangyuwei is a code owner

@SurbhiJainUSC SurbhiJainUSC Awaiting requested review from SurbhiJainUSC SurbhiJainUSC is a code owner

@hengtaoguo hengtaoguo Awaiting requested review from hengtaoguo hengtaoguo is a code owner

@A9isha A9isha Awaiting requested review from A9isha A9isha is a code owner

Assignees

@RissyRan RissyRan

@gobbleturk gobbleturk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gagika @RissyRan @gobbleturk