Fix config in maxengine #1339
Open
Fix config in maxengine #1339
+1
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tohaowu
requested review from
gobbleturk,
khatwanimohit,
bvandermoon,
vipannalla,
RissyRan,
richjames0,
rni418 and
gagika
as code owners
jwyang-google
approved these changes
Mar 4, 2025
bvandermoon
reviewed
Mar 5, 2025
bvandermoon
reviewed
Mar 5, 2025
There was a problem hiding this comment.
LGTM once the build test passes. Minor note - the link in the PR description points to this PR instead of PR 1285. Mind updating that?
| @@ -1166,7 +1166,6 @@ def create_engine_from_config_flags(batch_size, max_prefill_predict_length, max_ | |||
| option = f"{k}={v}" | |||
| updated_args.append(option) | |||
| print(f"Invoking maxengine with args:\n \t{updated_args}") | |||
| pyconfig.initialize(updated_args) | |||
| cfg = MaxEngineConfig(cp.deepcopy(pyconfig._config.keys)) # pylint: disable=protected-access | |||
There was a problem hiding this comment.
What error were you seeing without this change?
There was a problem hiding this comment.
Here is the error
Traceback (most recent call last):
File "<frozen runpy>", line 198, in _run_module_as_main
File "<frozen runpy>", line 88, in _run_code
File "/opt/maxtext/MaxText/inference_mlperf/offline_mode.py", line 535, in <module>
app.run(main)
File "/usr/local/lib/python3.12/dist-packages/absl/app.py", line 308, in run
_run_main(main, args)
File "/usr/local/lib/python3.12/dist-packages/absl/app.py", line 254, in _run_main
sys.exit(main(argv))
^^^^^^^^^^
File "/opt/maxtext/MaxText/inference_mlperf/offline_mode.py", line 467, in main
engine = create_engine_from_config_flags(
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/maxtext/MaxText/maxengine.py", line 1268, in create_engine_from_config_flags
cfg = MaxEngineConfig(cp.deepcopy(pyconfig._config.keys)) # pylint: disable=protected-access
^^^^^^^^^^^^^^^^
AttributeError: module 'pyconfig' has no attribute '_config'
|
Did you test this on TPU (Trillium) or GPU? Also can you please paste the error you see. cc @singh-mitali, PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the bug from pr/1285.
FIXES: b/396747968
Tests
Tested this code with MLPerf inference Llama2-70b
Checklist
Before submitting this PR, please make sure (put X in square brackets):