Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test scripts for llama2-7b int8/bf16 models #1347

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

xy12181
Copy link
Collaborator

@xy12181 xy12181 commented Mar 5, 2025

Tested:

$ ./MaxText/tests/inference/test_llama2_7b_int8.sh
$ ./MaxText/tests/inference/test_llama2_7b_bf16.sh

Description

Start with a short description of what the PR does and how this is a change from
the past.

The rest of the description includes relevant details and context, examples:

  • why is this change being made,
  • the problem being solved and any relevant context,
  • why this is a good solution,
  • some information about the specific implementation,
  • shortcomings of the solution and possible future improvements.

If the change fixes a bug or a Github issue, please include a link, e.g.,:
FIXES: b/123456
FIXES: #123456

Notice 1 Once all tests pass, the "pull ready" label will automatically be assigned. This label is used
for administrative purposes. Please do not add it manually.

Notice 2 For external contributions, our settings currently require an approval from a MaxText maintainer to trigger CI tests.

Tests

Please describe how you tested this change, and include any instructions and/or
commands to reproduce.

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed.

@xy12181
Copy link
Collaborator Author

xy12181 commented Mar 5, 2025

@vipannalla PTAL. Thanks!

@@ -0,0 +1,17 @@
python MaxText/decode.py MaxText/configs/base.yml \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: for future reference, I find it useful to

args=(
...
)
python "${args[@]}"

which allow us to add comment explain what an argument does.

Fine to keep as is

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. Thanks!

@xy12181
Copy link
Collaborator Author

xy12181 commented Mar 6, 2025

@vipannalla et al. could you please help review? thanks!

Tested:
```
$ ./MaxText/tests/inference/test_llama2_7b_int8.sh
$ ./MaxText/tests/inference/test_llama2_7b_bf16.sh
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants