Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate model_names for llama2-70b benchmarks #1356

Closed
wants to merge 2 commits into from

Conversation

bvandermoon
Copy link
Collaborator

@bvandermoon bvandermoon commented Mar 6, 2025

Description

There are several benchmarks named llama2_70b_4096. I tried to run this benchmark but was getting a different config then expected. A different llama2 benchmark with the same name was getting pulled instead of mine. This PR changes the other benchmark names to reduce duplicates.

Tests

  • Ran the benchmarks with the updated names and the workloads kicked off properly (although they fail for other reasons)

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed.

@bvandermoon bvandermoon closed this Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant