Use scan and hostoffloading for llama model
#123
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zpcore
commented
Feb 26, 2025
| @@ -20,3 +20,4 @@ attention_dropout: false | |||
| attention_bias: false | |||
| flash_attention: true | |||
| rope_theta: 500000.0 | |||
| scan_decoder_layers: true | |||
There was a problem hiding this comment.
move to default yaml file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port
scanandhostoffloadingfor llama model based on @tengyifei 's prototype in 1 and 2.The sharding schema in torchprime/torch_xla_models/configs/model/scaling/llama-fsdp.yaml also plays well with the
scancode.Currently there are
NaNissue when we use scan with flash attention kernel related to pytorch/xla#8734. Need to resolve the issue before producing the correct output.