Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for slurm-like commands #373

Merged
merged 59 commits into from
Feb 27, 2025
Merged

Fixes for slurm-like commands #373

merged 59 commits into from
Feb 27, 2025

Conversation

sharabiani
Copy link
Collaborator

Fixes / Features

  • Make updated to fix kjob and kueuectl installation
  • Errors for commands fixed while testing

Testing / Documentation

Testing details.

  • [ y/n ] Tests pass
  • [ y/n ] Appropriate changes to documentation are included in the PR

sharabiani and others added 11 commits February 17, 2025 12:17
@sharabiani
Fixes for slurm-like commands
6fac989
@pawloch00
add draft for gcs state bucket
3782051 
Signed-off-by: Piotr Pawłowski <[email protected]>
@pawloch00
draft
3c8c27d 
Signed-off-by: Piotr Pawłowski <[email protected]>
@pawloch00
Merge branch 'develop' into ppawl-add-gcs-param
d36e7b2
@pawloch00
remote state draft
7021264 
Signed-off-by: Piotr Pawłowski <[email protected]>
@pawloch00
fix
e4cf249 
Signed-off-by: Piotr Pawłowski <[email protected]>
@pawloch00
Merge branch 'develop' of https://github.com/AI-Hypercomputer/xpk int…
446cfe1 
…o ppawl-add-gcs-param
@pawloch00
Merge branch 'ppawl-add-gcs-param' of https://github.com/AI-Hypercomp…
ea16ae8 
…uter/xpk into ppawl-add-gcs-param
@sharabiani
JobTemplate updated based on cluster accelarator
c9cd809
@sharabiani
Conflicts resolved. JobTemplate updated based on cluster accelarator
fcdbb7c
@sharabiani
minor fixes after merge
1bbc990
@sharabiani sharabiani marked this pull request as ready for review February 20, 2025 14:43
pawloch00
pawloch00 reviewed Feb 20, 2025
View reviewed changes
pawloch00
pawloch00 reviewed Feb 20, 2025
View reviewed changes
@sharabiani sharabiani enabled auto-merge (squash) February 20, 2025 15:32
sharabiani and others added 16 commits February 23, 2025 21:58
@sharabiani
storage create location error fixed
cbcbdfd
@44past4
Initial scripts for multi-host fine-tuning example
bd31e9d
@pawloch00
Merge branch 'develop' of https://github.com/AI-Hypercomputer/xpk int…
0900204 
…o ppawl-add-gcs-param
@pawloch00
Merge branch 'ppawl-add-gcs-param' of https://github.com/AI-Hypercomp…
7b6e153 
…uter/xpk into ppawl-remote-state
@pawloch00
fix
f953c99 
Signed-off-by: Piotr Pawłowski <[email protected]>
@pawloch00
use remote state client class
aff4cf6 
Signed-off-by: Piotr Pawłowski <[email protected]>
@pawloch00
make remote state client optional
9c9d350 
Signed-off-by: Piotr Pawłowski <[email protected]>
@pawloch00
fix linter
27e61bd 
Signed-off-by: Piotr Pawłowski <[email protected]>
@pawloch00
fix modules
498f148 
Signed-off-by: Piotr Pawłowski <[email protected]>
@pawloch00
remote state upload working
f2c8809 
Signed-off-by: Piotr Pawłowski <[email protected]>
@pawloch00
fix
790d12c 
Signed-off-by: Piotr Pawłowski <[email protected]>
@pawloch00
fix
fb8b16c 
Signed-off-by: Piotr Pawłowski <[email protected]>
@pawloch00
change bucket layout
9b67e19 
Signed-off-by: Piotr Pawłowski <[email protected]>
@pawloch00
fix
6a8d71e 
Signed-off-by: Piotr Pawłowski <[email protected]>
@pawloch00
fix unittets
cfa7590 
Signed-off-by: Piotr Pawłowski <[email protected]>
@44past4
Switch back to use kjob main branch for building kjob
bc8429a 
Fix in kjob - kubernetes-sigs/kjob#63
@44past4 44past4 requested a review from RoshaniN as a code owner February 26, 2025 10:34
@sharabiani sharabiani merged commit 1171412 into develop Feb 27, 2025
3 checks passed
@sharabiani sharabiani deleted the slurm-fixes branch February 27, 2025 08:48
pawloch00 added a commit that referenced this pull request Feb 27, 2025
@pawloch00
Revert "Fixes for slurm-like commands (#373)"
362e2f8 
This reverts commit 1171412.
@pawloch00 pawloch00 mentioned this pull request Feb 27, 2025
Merged
@pawloch00 pawloch00 restored the slurm-fixes branch February 27, 2025 08:58
pawloch00 added a commit that referenced this pull request Feb 27, 2025
@pawloch00
Revert "Fixes for slurm-like commands (#373)" (#396)
57b32f9 
This reverts commit 1171412.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawloch00 pawloch00 pawloch00 approved these changes

@Obliviour Obliviour Awaiting requested review from Obliviour Obliviour is a code owner

@44past4 44past4 Awaiting requested review from 44past4 44past4 is a code owner

@BluValor BluValor Awaiting requested review from BluValor BluValor is a code owner

@gcie gcie Awaiting requested review from gcie gcie is a code owner

@RoshaniN RoshaniN Awaiting requested review from RoshaniN RoshaniN is a code owner

Assignees
No one assigned
Labels
release-bugfix release-improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sharabiani @pawloch00 @44past4