Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration Modules for creating user directory, configuration loading... #175

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Youbadawy
Copy link
Contributor

Dear all,

Hope this pull requests finds you all well and in good health,

Sorry for the delay, as requested this is a smaller pull request, with pep8 styling and documentation for the config items,

Goal of PR,

the primary aim for these modules is to facilitate the extraction of data, information, agents, and what not from a unified, standardized location in the repository ( ./user_data).

also I believe we should change the location of the config.json file that was put inside /notebooks to a central config folder in the parent directory. where we will put an example file to retrieve if any user need.

Whats next?

next we have the data fetching for crypto using the ccxt module.

@XiaoYangLiu-FinRL @BruceYanghy @spencerR1992

hope that meets the requirements...

@zhumingpassional
Copy link
Collaborator

thanks for your valuable codes.

could you pls separate this PR to several PRs?
In software engineering, we hope each PR solves only one problem.

In addition, this branch has conflicts with master. could you pls revise it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants