Wrap new named component functions #375
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ax3l
reviewed
Oct 9, 2024
Comment on lines
+212
to
215
| .def("add_real_comp", py::overload_cast<const std::string&, int>(&ParticleContainerType::AddRealComp), | ||
| py::arg("communicate")=true, "add a new runtime component with type Real") | ||
| .def("add_int_comp", py::overload_cast<const std::string&, int>(&ParticleContainerType::AddIntComp), | ||
| py::arg("communicate")=true, "add a new runtime component with type Int") |
There was a problem hiding this comment.
Extra py::arg("name") needed. I cherry-picked this to #379 and completed it :)
ax3l
added a commit
that referenced
this pull request
Oct 10, 2024
Update to latest commit in `development`. Includes upstream named SoA components. Includes updated APIs from #375 --------- Co-authored-by: Andrew Myers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wraps new functions added in PR #4163.