Investigate screen flickering on WSL/Windows Terminal #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I test using the new code, and find it always print when I moving my mouse. Further, I found that everything I do that can make program to get an |
|
Can you check if the latest commit fixed the problem? |
|
Yes! |
|
The solution I pushed now is hacky. It will get cleaned up when I merge #119. Anyways I am merging this. |
|
Merged. Thanks @EiEddie for all your help. |
AMythicDev
added a commit
that referenced
this pull request
Dec 18, 2023
The flickering was caused due to screen being redrawn even on `InputEvent::Ignore` events Closes #120
|
@EiEddie I have pushed a patch release containing these changes. You can get it from crates.io. |
AMythicDev
added a commit
that referenced
this pull request
Dec 18, 2023
The flickering was caused due to screen being redrawn even on `InputEvent::Ignore` events Closes #120
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@EiEddie can you test your code from this branch?. It will print out the events on the screen before handling them on the screen. This will help us investigate all the events that the event reader is reading.