Skip to content

Commit

Permalink
Merge pull request #2622 from ASFHyP3/restrict-sns-perms
Browse files Browse the repository at this point in the history
restrict sns publish to same region and account
  • Loading branch information
jtherrmann authored Feb 25, 2025
2 parents 861e58e + df6ccbe commit 6ecbba7
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Added
- `ARIA_S1_GUNW` job type to hyp3-edc-uat deployment.
- All jobs now have `sns:Publish` permissions for all SNS topics.
- All jobs now have `sns:Publish` permissions for SNS topics in the same AWS region and account for the purpose of sending messages to a co-located deployment of <https://github.com/ASFHyP3/ingest-adapter>.

### Changed
- The reserved `bucket_prefix` job spec parameter has been renamed to `job_id` and can be referenced as `Ref::job_id` within each step's `command` field.
Expand Down
2 changes: 1 addition & 1 deletion apps/compute-cf.yml.j2
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ Resources:
Resource: !Sub "arn:aws:s3:::${ContentBucket}/*"
- Effect: Allow
Action: sns:Publish
Resource: "arn:aws:sns:*"
Resource: !Sub "arn:aws:sns:${AWS::Region}:${AWS::AccountId}:*"

BatchServiceRole:
Type: {{ 'Custom::JplRole' if security_environment in ('JPL', 'JPL-public') else 'AWS::IAM::Role' }}
Expand Down

0 comments on commit 6ecbba7

Please sign in to comment.