Merge pull request #2611 from ASFHyP3/edc-s3-read

quote -z expressions to allow for whitespace in variable values
ASFHyP3 · Feb 20, 2025 · 7b2f54a · 7b2f54a
2 parents b8ab6b0 + e0ef04d
commit 7b2f54a
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/.github/actions/deploy-hyp3/action.yml b/.github/actions/deploy-hyp3/action.yml
@@ -90,19 +90,19 @@ runs:
       - name: Package and deploy
         shell: bash
         run: |
-          [ -z ${{ inputs.CLOUDFORMATION_ROLE_ARN }} ] && export ROLE_STATEMENT="" \
+          [ -z "${{ inputs.CLOUDFORMATION_ROLE_ARN }}" ] && export ROLE_STATEMENT="" \
             || export ROLE_STATEMENT="--role-arn ${{ inputs.CLOUDFORMATION_ROLE_ARN }}"
 
-          [ -z ${{ inputs.DOMAIN_NAME }} ] && export DOMAIN_NAME="" \
+          [ -z "${{ inputs.DOMAIN_NAME }}" ] && export DOMAIN_NAME="" \
             || export DOMAIN_NAME="DomainName='${{ inputs.DOMAIN_NAME }}'"
 
-          [ -z ${{ inputs.CERTIFICATE_ARN }} ] && export CERTIFICATE_ARN="" \
+          [ -z "${{ inputs.CERTIFICATE_ARN }}" ] && export CERTIFICATE_ARN="" \
             || export CERTIFICATE_ARN="CertificateArn='${{ inputs.CERTIFICATE_ARN }}'"
 
-          [ -z ${{ inputs.BUCKET_READ_PRINCIPALS }} ] && export BUCKET_READ_PRINCIPALS="" \
+          [ -z "${{ inputs.BUCKET_READ_PRINCIPALS }}" ] && export BUCKET_READ_PRINCIPALS="" \
             || export BUCKET_READ_PRINCIPALS="BucketReadPrincipals='${{ inputs.BUCKET_READ_PRINCIPALS }}'"
 
-          [ -z ${{ inputs.DISTRIBUTION_URL }} ] && export DISTRIBUTION_URL="" \
+          [ -z "${{ inputs.DISTRIBUTION_URL }}" ] && export DISTRIBUTION_URL="" \
             || export DISTRIBUTION_URL="DistributionUrl='${{ inputs.DISTRIBUTION_URL }}'"
 
           aws cloudformation package \