Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix naming to use Resource Quota consistently #118

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

bastian-src
Copy link
Contributor

Settings, error messages, and views use occasionally "Resource quota" instead of "Resource Quota".

Copy link
Contributor

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Bastian, diff LGTM. GHA are red. Is that related to your PR? If so, please investigate.

@bastian-src
Copy link
Contributor Author

Thanks for your review already, I'm having a look on the tests!

@bastian-src bastian-src force-pushed the fix/make_settings_wording_consistent branch from aa8c031 to 8336258 Compare February 7, 2025 14:44
Settings, error messages, API definitions, and views use occasionally
"Resource quota" or "resource quota" instead of "Resource Quota".
@bastian-src bastian-src force-pushed the fix/make_settings_wording_consistent branch from 8336258 to 0a0918f Compare February 7, 2025 16:10
@bastian-src
Copy link
Contributor Author

Fix ruby tests - Rails::RecordInvalid error inflects certain cases of Resource quota in error messages. Since these are not directly prompted to the user, I'd say it's okay to keep them. This is relevant in the Host Managed Tests, here.

@maximiliankolb please re-review :)

Copy link
Contributor

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bastian-src bastian-src merged commit 070d8f8 into main Feb 10, 2025
13 checks passed
@maximiliankolb maximiliankolb deleted the fix/make_settings_wording_consistent branch February 10, 2025 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants