Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for scc_manager.rb #148

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add tests for scc_manager.rb #148

wants to merge 1 commit into from
+64 −0

Conversation

bastian-src
Copy link
Contributor

@bastian-src bastian-src commented Mar 5, 2025 •
edited
Loading

This PR adds new tests for the app/lib/scc_manager.rb file which contains a helper method to preform get requests to the SCC service.

@bastian-src bastian-src force-pushed the feature/tests/add_scc_manager_requests_tests branch from f9c3a29 to 6b03b69 Compare March 5, 2025 11:56
@bastian-src
Copy link
Contributor Author

packit error seems unrelated:

NFO: Pulling image: registry.fedoraproject.org/fedora:41
ERROR: b''
b'Trying to pull registry.fedoraproject.org/fedora:41...\nError: copying system image from manifest list: parsing image configuration: fetching blob: received unexpected HTTP status: 502 Bad Gateway\n'
INFO: Pulling image: registry.fedoraproject.org/fedora:41

@bastian-src bastian-src force-pushed the feature/tests/add_scc_manager_requests_tests branch from 6b03b69 to 2ead4b5 Compare March 5, 2025 12:06
nadjaheitmann
nadjaheitmann approved these changes Mar 5, 2025
View reviewed changes
Copy link
Collaborator

@nadjaheitmann nadjaheitmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Thanks for adding new tests here!

@bastian-src bastian-src force-pushed the feature/tests/add_scc_manager_requests_tests branch from 2ead4b5 to 7e75cff Compare March 5, 2025 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nadjaheitmann nadjaheitmann nadjaheitmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bastian-src @nadjaheitmann